-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMN-792 Add events service v2 in agreement-platformstate-writer #987
IMN-792 Add events service v2 in agreement-platformstate-writer #987
Conversation
…N-798_catalog-platformstate-writer-v2
…N-798_catalog-platformstate-writer-v2
…hub.com/pagopa/interop-be-monorepo into IMN-798_catalog-platformstate-writer-v2
…hub.com/pagopa/interop-be-monorepo into IMN-798_catalog-platformstate-writer-v2
…atalog-platformstate-writer-v1
…atalog-platformstate-writer-v1
…lient-assertion-validation
…IMN-792_agreement-platform-state-writer-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
only open point IMO is the handling of missing catalog entry
packages/agreement-platformstate-writer/src/consumerServiceV2.ts
Outdated
Show resolved
Hide resolved
packages/agreement-platformstate-writer/src/consumerServiceV2.ts
Outdated
Show resolved
Hide resolved
if (!catalogEntry) { | ||
// TODO double-check | ||
throw genericInternalError("Catalog entry not found"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the entry has not been found we could be one of these cases
- the descriptor has been archived right before the upgrade event arrives (bad luck)
- the descriptor has been archived and this is a reprocess
- an error has blocked the consumer of catalog events
We should be able to cover all of them by setting the INACTIVE
state.
In theory in this case other descriptor details (eg audience) should be left blank. Is it feasible in your opinion?
packages/agreement-platformstate-writer/src/consumerServiceV2.ts
Outdated
Show resolved
Hide resolved
packages/agreement-platformstate-writer/test/consumerServiceV2.integration.test.ts
Outdated
Show resolved
Hide resolved
packages/agreement-platformstate-writer/test/consumerServiceV2.integration.test.ts
Outdated
Show resolved
Hide resolved
…github.com/pagopa/interop-be-monorepo into IMN-792_agreement-platform-state-writer-v2
I think the easiest solution is ignoring the updates on the descriptor fields if catalog entry is |
it works for me |
[To be merged after #967]
This pull request is for implementing the v2 consumer service in
agreement-platformstate-writer
.